Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sanity): add release types #7619

Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat(sanity): add release types #7619

merged 3 commits into from
Oct 16, 2024

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Oct 15, 2024 •
edited
Loading

Description

Add release types to bundles metadata (asap, scheduled or undecided)
Names are still in flux, these seemed to be the ones that we would least regret in the long run as well as make it clearer from a code standpoint, I'm open to other suggestions though!

Also, we were planning on having these properties exist in a separate place other than the bundle metadata, but due to limitations outside of our control this is the temporary solution

What to review

Does the code provided make sense?
Keep in mind, this is simply for unblocking us in continuing corel development, the actual development and changes to the modal will be done in a separate task and so are out of scope

Testing

Updated tests to pass

@RitaDias RitaDias requested review from a team and bjoerge October 15, 2024 07:06
@RitaDias RitaDias requested a review from a team as a code owner October 15, 2024 07:06
@RitaDias RitaDias requested review from ricokahler and removed request for a team October 15, 2024 07:06
@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:13pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:13pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:13pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:13pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:13pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 1:13pm

@RitaDias RitaDias removed the request for review from ricokahler October 15, 2024 07:06
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Component Testing Report Updated Oct 16, 2024 1:12 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 19s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 28s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 38s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Wed, 16 Oct 2024 13:24:21 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 18.3 efps (55ms) 13.9 efps (72ms) +18ms (+32.1%) 🔴
article (body) 59.9 efps (17ms) 63.1 efps (16ms) -1ms (-5.1%) ✅
article (string inside object) 19.6 efps (51ms) 14.9 efps (67ms) +16ms (+31.4%) 🔴
article (string inside array) 15.5 efps (65ms) 12.0 efps (83ms) +19ms (+28.7%) 🔴
recipe (name) 32.3 efps (31ms) 21.7 efps (46ms) +15ms (+48.4%) 🔴
recipe (description) 35.7 efps (28ms) 22.7 efps (44ms) +16ms (+57.1%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (6ms) -1ms (-/-%) ✅
synthetic (title) 15.4 efps (65ms) 6.1 efps (163ms) +98ms (+150.8%) 🔴
synthetic (string inside object) 16.0 efps (63ms) 6.5 efps (155ms) +93ms (+148.0%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 61ms 74ms 217ms 453ms 13.1s
article (body) 17ms 19ms 26ms 178ms 273ms 5.6s
article (string inside object) 51ms 53ms 60ms 149ms 134ms 8.1s
article (string inside array) 65ms 67ms 74ms 215ms 775ms 9.4s
recipe (name) 31ms 33ms 36ms 84ms 0ms 8.5s
recipe (description) 28ms 30ms 33ms 143ms 0ms 6.0s
recipe (instructions) 7ms 8ms 8ms 10ms 0ms 3.2s
synthetic (title) 65ms 71ms 80ms 466ms 1525ms 15.3s
synthetic (string inside object) 63ms 65ms 72ms 543ms 1404ms 9.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 72ms 79ms 96ms 304ms 2037ms 15.5s
article (body) 16ms 19ms 21ms 261ms 382ms 5.6s
article (string inside object) 67ms 71ms 75ms 169ms 1840ms 9.9s
article (string inside array) 83ms 86ms 95ms 256ms 2611ms 11.3s
recipe (name) 46ms 48ms 53ms 107ms 663ms 10.2s
recipe (description) 44ms 47ms 51ms 165ms 490ms 7.7s
recipe (instructions) 6ms 8ms 9ms 23ms 0ms 3.2s
synthetic (title) 163ms 176ms 201ms 361ms 9529ms 25.6s
synthetic (string inside object) 155ms 161ms 170ms 1125ms 8698ms 19.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias requested a review from bjoerge October 16, 2024 13:19
@RitaDias RitaDias merged commit ea3adca into corel Oct 16, 2024
53 of 62 checks passed
@RitaDias RitaDias deleted the add-release-type branch October 16, 2024 13:29
RitaDias added a commit that referenced this pull request Oct 17, 2024
@RitaDias
feat(sanity): add release types (#7619)
1fbe95f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RitaDias @bjoerge